[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [PULL v2 00/54] s390x update

From: Peter Maydell
Subject: Re: [qemu-s390x] [PULL v2 00/54] s390x update
Date: Tue, 21 May 2019 14:53:57 +0100

On Tue, 21 May 2019 at 14:31, Cornelia Huck <address@hidden> wrote:
> On Tue, 21 May 2019 14:24:07 +0100
> Peter Maydell <address@hidden> wrote:
> > ...it's copying the file into asm-arm/ rather than asm-arm64/.
> > (I did a by-hand move of the file into the right directory and
> > that was sufficient for the compile to succeed.)
> I'm obviously not at my best at the moment :(

No big deal, it's always awkward when you don't have access
to the test hardware.

> >
> > Also, can we keep the changes to scripts/ in a separate
> > commit, please? The idea of header-update commits is that they
> > should contain only the changes automatically generated
> > by the script, with no hand-written additions.
> This looks a bit like a chicken-and-egg problem, though... without the
> change, we cannot point the script at a current kernel tree. I'd prefer
> the two to stay together, but I can certainly point out the change to
> the script more prominently.

I would structure it as:

Commit 1: update the script
Commit 2: result of running the script

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]