[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [Qemu-devel] [PATCH v1 20/41] s390x/tcg: Implement VECT
From: |
Richard Henderson |
Subject: |
Re: [qemu-s390x] [Qemu-devel] [PATCH v1 20/41] s390x/tcg: Implement VECTOR MULTIPLY * |
Date: |
Fri, 12 Apr 2019 14:04:20 -1000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 4/11/19 12:08 AM, David Hildenbrand wrote:
> +static void gen_mh_i32(TCGv_i32 d, TCGv_i32 a, TCGv_i32 b)
> +{
> + TCGv_i64 t0 = tcg_temp_new_i64();
> + TCGv_i64 t1 = tcg_temp_new_i64();
> +
> + tcg_gen_ext_i32_i64(t0, a);
> + tcg_gen_ext_i32_i64(t1, b);
> + tcg_gen_mul_i64(t0, t0, t1);
> + tcg_gen_extrh_i64_i32(d, t0);
This is
tcg_gen_muls2_i32(tmp, d, a, b);
Similarly for mlh w/ mulu2.
Otherwise,
Reviewed-by: Richard Henderson <address@hidden>
r~
- Re: [qemu-s390x] [Qemu-devel] [PATCH v1 17/41] s390x/tcg: Implement VECTOR LOAD POSITIVE, (continued)
- [qemu-s390x] [PATCH v1 21/41] s390x/tcg: Implement VECTOR NAND, David Hildenbrand, 2019/04/11
- [qemu-s390x] [PATCH v1 18/41] s390x/tcg: Implement VECTOR (MAXIMUM|MINIMUM) (LOGICAL), David Hildenbrand, 2019/04/11
- [qemu-s390x] [PATCH v1 16/41] s390x/tcg: Implement VECTOR LOAD COMPLEMENT, David Hildenbrand, 2019/04/11
- [qemu-s390x] [PATCH v1 22/41] s390x/tcg: Implement VECTOR NOR, David Hildenbrand, 2019/04/11
- [qemu-s390x] [PATCH v1 20/41] s390x/tcg: Implement VECTOR MULTIPLY *, David Hildenbrand, 2019/04/11
- Re: [qemu-s390x] [Qemu-devel] [PATCH v1 20/41] s390x/tcg: Implement VECTOR MULTIPLY *,
Richard Henderson <=
- [qemu-s390x] [PATCH v1 19/41] s390x/tcg: Implement VECTOR MULTIPLY AND ADD *, David Hildenbrand, 2019/04/11
- [qemu-s390x] [PATCH v1 14/41] s390x/tcg: Implement VECTOR EXCLUSIVE OR, David Hildenbrand, 2019/04/11
- [qemu-s390x] [PATCH v1 06/41] s390x/tcg: Implement VECTOR AND (WITH COMPLEMENT), David Hildenbrand, 2019/04/11
- [qemu-s390x] [PATCH v1 15/41] s390x/tcg: Implement VECTOR GALOIS FIELD MULTIPLY SUM (AND ACCUMULATE), David Hildenbrand, 2019/04/11