[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [PATCH v4 1/6] vfio-ccw: make it safe to access channel

From: Eric Farman
Subject: Re: [qemu-s390x] [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs
Date: Mon, 8 Apr 2019 16:25:11 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0

On 4/8/19 1:07 PM, Cornelia Huck wrote:
On Mon, 8 Apr 2019 13:02:12 -0400
Farhan Ali <address@hidden> wrote:

On 03/01/2019 04:38 AM, Cornelia Huck wrote:
When we get a solicited interrupt, the start function may have
been cleared by a csch, but we still have a channel program
structure allocated. Make it safe to call the cp accessors in
any case, so we can call them unconditionally.

While at it, also make sure that functions called from other parts
of the code return gracefully if the channel program structure
has not been initialized (even though that is a bug in the caller).

Reviewed-by: Eric Farman<address@hidden>
Signed-off-by: Cornelia Huck<address@hidden>

Hi Connie,

My series of fixes for vfio-ccw depends on this patch as I would like to
call cp_free unconditionally :) (I had developed my code on top of your

Could we pick this patch up as well when/if you pick up my patch series?
I am in the process of sending out a v2.

Regarding this patch we could merge it as a stand alone patch, separate
from this series. And also the patch LGTM

Reviewed-by: Farhan Ali <address@hidden>

Actually, I wanted to ask how people felt about merging this whole
series for the next release :) It would be one thing less on my plate...

I'm not opposed to it. Every time I try to review patches 4 and 6 I get an asynchronous interrupt of my own. :) I'll at least get you an ack in the next day or two.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]