Re: [qemu-s390x] [PATCH 09/15] s390x/kvm: Report warnings with warn_report(), not error_printf()

[Thomas Huth]

On 08/04/2019 10.36, Markus Armbruster wrote:
> kvm_s390_mem_op() can fail in two ways: when !cap_mem_op, it returns
> -ENOSYS, and when kvm_vcpu_ioctl() fails, it returns -errno set by
> ioctl().  Its caller s390_cpu_virt_mem_rw() recovers from both
> failures.
> 
> kvm_s390_mem_op() prints "KVM_S390_MEM_OP failed" with error_printf()
> in the latter failure mode.  Since this is obviously a warning, use
> warn_report().
> 
> Perhaps the reporting should be left to the caller.  It could warn on
> failure other than -ENOSYS.
> 
> Cc: Thomas Huth <address@hidden>
> Cc: address@hidden
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  target/s390x/kvm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c
> index 19530fb94e..2c6e35b5aa 100644
> --- a/target/s390x/kvm.c
> +++ b/target/s390x/kvm.c
> @@ -782,7 +782,7 @@ int kvm_s390_mem_op(S390CPU *cpu, vaddr addr, uint8_t ar, 
> void *hostbuf,
>  
>      ret = kvm_vcpu_ioctl(CPU(cpu), KVM_S390_MEM_OP, &mem_op);
>      if (ret < 0) {
> -        error_printf("KVM_S390_MEM_OP failed: %s\n", strerror(-ret));
> +        warn_report("KVM_S390_MEM_OP failed: %s", strerror(-ret));
>      }
>      return ret;
>  }
> 

Reviewed-by: Thomas Huth <address@hidden>