Re: [qemu-s390x] [PATCH v5 01/15] s390 vfio-ccw: Add bootindex property and IPLB data

[Cornelia Huck]

On Tue, 26 Mar 2019 13:49:41 +0100
Thomas Huth <address@hidden> wrote:

> On 13/03/2019 17.31, Jason J. Herne wrote:
> > Add bootindex property and iplb data for vfio-ccw devices. This allows us to
> > forward boot information into the bios for vfio-ccw devices.
> > 
> > Refactor s390_get_ccw_device() to return device type. This prevents us from
> > having to use messy casting logic in several places.
> > 
> > Signed-off-by: Jason J. Herne <address@hidden>
> > Acked-by: Halil Pasic <address@hidden>
> > Reviewed-by: Cornelia Huck <address@hidden>
> > ---  

> [...]
> > diff --git a/include/hw/s390x/vfio-ccw.h b/include/hw/s390x/vfio-ccw.h
> > new file mode 100644
> > index 0000000..2fceaa2
> > --- /dev/null
> > +++ b/include/hw/s390x/vfio-ccw.h
> > @@ -0,0 +1,28 @@
> > +/*
> > + * vfio based subchannel assignment support
> > + *
> > + * Copyright 2017 IBM Corp.  
> 
> Maybe bump the year to 2019 ?

Not sure, the code is simply extracted and not changed, isn't it?

(If bumped, it probably should be 2017,2019.)

> 
> > + * Author(s): Dong Jia Shi <address@hidden>
> > + *            Xiao Feng Ren <address@hidden>
> > + *            Pierre Morel <address@hidden>
> > + *
> > + * This work is licensed under the terms of the GNU GPL, version 2 or (at
> > + * your option) any later version. See the COPYING file in the top-level
> > + * directory.
> > + */
> > +
> > +#ifndef HW_VFIO_CCW_H
> > +#define HW_VFIO_CCW_H
> > +
> > +#include "hw/vfio/vfio-common.h"
> > +#include "hw/s390x/s390-ccw.h"
> > +#include "hw/s390x/ccw-device.h"
> > +
> > +#define TYPE_VFIO_CCW "vfio-ccw"
> > +#define VFIO_CCW(obj) \
> > +        OBJECT_CHECK(VFIOCCWDevice, (obj), TYPE_VFIO_CCW)
> > +
> > +#define TYPE_VFIO_CCW "vfio-ccw"
> > +typedef struct VFIOCCWDevice VFIOCCWDevice;
> > +
> > +#endif  
> 
> Reviewed-by: Thomas Huth <address@hidden>