[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH] target/s390x: Remove non-architected entries fr
|
From: |
Thomas Huth |
|
Subject: |
Re: [qemu-s390x] [PATCH] target/s390x: Remove non-architected entries from struct LowCore |
|
Date: |
Tue, 5 Mar 2019 08:12:55 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 |
On 05/03/2019 08.09, Thomas Huth wrote:
> There are some fields in our struct LowCore which apparently have
> been copied from a very old version of the Linux kernel. These
> fields are not architected in the "Principles of Operation", and
> only used on these memory locations in Linux kernels older than
> 2.6.29. Newer Linux kernels moved the entries to different locations
> or are not using them at all anymore. Thus we should never access
> these fields from the QEMU side, so they should be removed.
>
> While we're at it, also add a QEMU_BUILD_BUG_MSG() statement to
> assert that struct LowCore has the right size.
Uh, sorry, wrong version of the patch, please ignore, I did not add the
QEMU_BUILD_BUG_MSG() here yet. I'll send a v2 in a minute...
Thomas