Re: [qemu-s390x] [PATCH v3 16/16] s390-bios: dasd-ipl: Use control unit type to customize error data

[Cornelia Huck]

On Fri,  1 Mar 2019 13:59:36 -0500
"Jason J. Herne" <address@hidden> wrote:

> Propagate control unit type from main through the dasd ipl call chain.
> The control unit type can be used to determine if we are attempting to
> boot from a real dasd device. If something goes wrong we'll want to print
> detailed dasd sense data (for diagnostic use) but only if we're attempting
> to boot from a real dasd device.
> 
> Note: We also query and print the dasd sense data if we fail while
> attempting to determine the control unit type. In this case, we don't know
> if we're dealing with a real dasd device yet, but if we are, then the sense
> data may be useful for figuring out what went wrong. Since determining
> the control unit type is the very first thing we do with any real dasd device,
> this is our most likely point of failure.

Yeah, it probably does not hurt to print it out, even if it isn't
correct. If there's a non-dasd specific error, it's likely in the first
sense byte anyway.

> 
> Signed-off-by: Jason J. Herne <address@hidden>
> ---
>  pc-bios/s390-ccw/cio.c      | 16 ++++++++++------
>  pc-bios/s390-ccw/cio.h      |  6 ++++--
>  pc-bios/s390-ccw/dasd-ipl.c | 25 +++++++++++++------------
>  pc-bios/s390-ccw/dasd-ipl.h |  2 +-
>  pc-bios/s390-ccw/main.c     |  2 +-
>  pc-bios/s390-ccw/virtio.c   |  2 +-
>  6 files changed, 30 insertions(+), 23 deletions(-)

I think it would make sense to squash this into the patches you
mentioned in the cover letter in the next version.