Re: [qemu-s390x] [PATCH 11/15] s390-bios: cio error handling

[Cornelia Huck]

On Thu, 28 Feb 2019 10:59:13 -0500
"Jason J. Herne" <address@hidden> wrote:

> On 2/4/19 6:41 AM, Cornelia Huck wrote:

> >> @@ -148,6 +370,9 @@ int do_cio(SubChannelId schid, uint32_t ccw_addr, int 
> >> fmt)
> >>               continue;
> >>           }
> >>   
> >> +        print_irb_err(&irb);
> >> +        basic_sense(schid, &sd, sizeof(sd));
> >> +        print_eckd_dasd_sense_data(&sd);  
> > 
> > I think this should only be printed for actual dasds (and maybe only
> > print it if there is actually sense data available)?
> >   
> 
> Good point. Currently do_cio doesn't have any info on its device type. Should 
> I pass in 
> the controller type? Thats the easiest way I can think of to make the 
> decision.
> 

Sounds reasonable to me!