[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[qemu-s390x] [PULL 05/10] s390x/pci: mark zpci devices as unmigratable
From: |
Cornelia Huck |
Subject: |
[qemu-s390x] [PULL 05/10] s390x/pci: mark zpci devices as unmigratable |
Date: |
Tue, 5 Feb 2019 17:41:04 +0100 |
We currently don't migrate any state for zpci devices, which are
coupled with standard pci devices. This means funny things happen
when we e.g. try to migrate with a virtio-pci device but the s390x-
specific zpci state is not migrated (vfio-pci is not affected, as
it is not migratable anyway.)
Until this is fixed, mark zpci devices as unmigratable.
Reported-by: David Hildenbrand <address@hidden>
Reviewed-by: David Hildenbrand <address@hidden>
Reviewed-by: Collin Walling <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>
---
hw/s390x/s390-pci-bus.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
index c96a7cba34..96c7c18f3f 100644
--- a/hw/s390x/s390-pci-bus.c
+++ b/hw/s390x/s390-pci-bus.c
@@ -1253,6 +1253,15 @@ static Property s390_pci_device_properties[] = {
DEFINE_PROP_END_OF_LIST(),
};
+static const VMStateDescription s390_pci_device_vmstate = {
+ .name = TYPE_S390_PCI_DEVICE,
+ /*
+ * TODO: add state handling here, so migration works at least with
+ * emulated pci devices on s390x
+ */
+ .unmigratable = 1,
+};
+
static void s390_pci_device_class_init(ObjectClass *klass, void *data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
@@ -1263,6 +1272,7 @@ static void s390_pci_device_class_init(ObjectClass
*klass, void *data)
dc->bus_type = TYPE_S390_PCI_BUS;
dc->realize = s390_pci_device_realize;
dc->props = s390_pci_device_properties;
+ dc->vmsd = &s390_pci_device_vmstate;
}
static const TypeInfo s390_pci_device_info = {
--
2.17.2
- [qemu-s390x] [PULL 00/10] s390x update, Cornelia Huck, 2019/02/05
- [qemu-s390x] [PULL 01/10] target/s390x: define TCG_GUEST_DEFAULT_MO for MTTCG, Cornelia Huck, 2019/02/05
- [qemu-s390x] [PULL 02/10] s390x: remove direct reference to mem_path global from s390x code, Cornelia Huck, 2019/02/05
- [qemu-s390x] [PULL 03/10] s390x/pci: Introduce unplug requests and split unplug handler, Cornelia Huck, 2019/02/05
- [qemu-s390x] [PULL 05/10] s390x/pci: mark zpci devices as unmigratable,
Cornelia Huck <=
- [qemu-s390x] [PULL 04/10] s390x/pci: Drop release timer and replace it with a flag, Cornelia Huck, 2019/02/05
- [qemu-s390x] [PULL 07/10] s390x/pci: Fix primary bus number for PCI bridges, Cornelia Huck, 2019/02/05
- [qemu-s390x] [PULL 06/10] s390x/tcg: Don't model FP registers as globals, Cornelia Huck, 2019/02/05
- [qemu-s390x] [PULL 08/10] s390x/pci: Fix hotplugging of PCI bridges, Cornelia Huck, 2019/02/05
- [qemu-s390x] [PULL 09/10] s390x/pci: Warn when adding PCI devices without the 'zpci' feature, Cornelia Huck, 2019/02/05
- [qemu-s390x] [PULL 10/10] s390x/pci: Unplug remaining requested devices on pcihost reset, Cornelia Huck, 2019/02/05
- Re: [qemu-s390x] [PULL 00/10] s390x update, Peter Maydell, 2019/02/05