Re: [qemu-s390x] [PATCH v2] s390x: express dependencies with Kconfig

[Paolo Bonzini]

On 29/01/19 10:49, Cornelia Huck wrote:
> On Tue, 29 Jan 2019 10:42:14 +0100
> Thomas Huth <address@hidden> wrote:
> 
>> Instead of hard-coding all config switches in the config file
>> default-configs/s390x-softmmu.mak, let's use the new Kconfig files
>> to express the necessary dependencies: The S390_CCW_VIRTIO config switch
>> for the "s390-ccw-virtio" machine now selects all non-optional devices.
>>
>> And since we already have the VIRTIO_PCI and VIRTIO_MMIO config switches
>> for the other two virtio transports, this patch also introduces a new
>> config switch VIRTIO_CCW for the third, s390x-specific virtio transport,
>> so that all three virtio transports are now handled in the same way.
>>
>> Signed-off-by: Thomas Huth <address@hidden>
>> ---
>>  v2:
>>  - Use CONFIG_TERMINAL3270 for 3270-ccw.o
>>  - Use CONFIG_VIRTIO_CCW for all related devices in the Makefile
>>
>>  default-configs/s390x-softmmu.mak | 12 ++++++++----
>>  hw/s390x/Kconfig                  |  4 ++++
>>  hw/s390x/Makefile.objs            |  4 +++-
>>  hw/virtio/Kconfig                 |  4 ++++
>>  4 files changed, 19 insertions(+), 5 deletions(-)
> 
> Looks sane to me.
> 
> As I have not looked into the Kconfig infrastructure, I don't feel
> comfortable enough to give a R-b, but have a
> 
> Acked-by: Cornelia Huck <address@hidden>
> 

Thanks.  Yang, can you integrate it into the next version?

Paolo