[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [PATCH 21/22] event-facility: ChangeSysBusDeviceClass *

From: maozy
Subject: Re: [qemu-s390x] [PATCH 21/22] event-facility: ChangeSysBusDeviceClass *sbdc to SysBusDeviceClass *sbc
Date: Tue, 20 Nov 2018 09:10:46 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0

On 11/19/18 10:10 PM, Thomas Huth wrote:
On 2018-11-19 13:25, Cornelia Huck wrote:
On Mon, 19 Nov 2018 20:08:19 +0800
Mao Zhongyi <address@hidden> wrote:

Most of the SysBusDeviceClass variables are named sbc,
and sbdc here is a bit weird, so changing sbdc to keep
it consistent with others might look good.

A quick git grep also gives sbd and k as variable names, and it is used
in a total of two lines which have not been touched since 2013, so...
meh. If others like the change, I'm not opposed to merging, though.

I think I agree with Cornelia, just changing the variable name because
it's named differently in a couple of other places is just unnecessary
code churn, which makes "git blame" output harder to read later. I'd
suggest to drop this patch, too.

Ok, I got it. :)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]