Re: [qemu-s390x] [PATCH v10 3/6] s390x/kvm: enable AP instruction interpretation for guest

[Cornelia Huck]

On Wed, 10 Oct 2018 13:38:51 +0200
Halil Pasic <address@hidden> wrote:

> On 10/09/2018 07:52 PM, Tony Krowiak wrote:

> > +static void kvm_s390_configure_apie(bool interpret)
> > +{
> > +    uint64_t attr = interpret ? KVM_S390_VM_CRYPTO_ENABLE_APIE :
> > +                                KVM_S390_VM_CRYPTO_DISABLE_APIE;
> > +
> > +    if (kvm_vm_check_attr(kvm_state, KVM_S390_VM_CRYPTO, attr)) {  
> 
> Not sure this check is necessary, and that the behavior if it fails
> is intuitive, but whatever.

It's not an uncommon pattern, and this is not a call where performance
matters, so it's fine with me.

> 
> > +        kvm_s390_set_attr(attr);
> > +    }
> > +}
> > +