[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v9 4/6] s390x/ap: base Adjunct Processor (AP) ob
Re: [qemu-s390x] [PATCH v9 4/6] s390x/ap: base Adjunct Processor (AP) object model
Fri, 28 Sep 2018 16:22:12 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
On 09/27/2018 02:29 PM, Thomas Huth wrote:
>> +static void vfio_ap_bus_class_init(ObjectClass *klass, void *data)
>> + BusClass *k = BUS_CLASS(klass);
> I think calling the variable "oc" (or something similar) instead of
> "klass" is prefered nowadays.
>> + k->get_dev_path = vfio_ap_bus_get_dev_path;
>> + /* More than one vfio-ap device does not make sense */
>> + k->max_dev = 1;
> Would it make sense to set a DEVICE_CATEGORY here, too?
It would be
People seem to do this, but I'm not sure what is the actual impact of having
DEVICE_CATEGORY_MISC set or not set, except for vfio_ap being listed as misc
or uncategorized device respectively. Currently we have loader and vfio-ap
uncategorized. Should loader become MISC too?
[qemu-s390x] [PATCH v9 3/6] s390x/kvm: enable AP instruction interpretation for guest, Tony Krowiak, 2018/09/26
[qemu-s390x] [PATCH v9 2/6] s390x/cpumodel: Set up CPU model for AP device support, Tony Krowiak, 2018/09/26