[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v3 5/9] s390x/tcg: add instruction flags for flo
From: |
David Hildenbrand |
Subject: |
Re: [qemu-s390x] [PATCH v3 5/9] s390x/tcg: add instruction flags for floating point instructions |
Date: |
Thu, 27 Sep 2018 13:39:22 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 27/09/2018 13:07, Thomas Huth wrote:
> On 2018-09-17 11:34, David Hildenbrand wrote:
>> These flags allow us to later on detect if a DATA program interrupt
>> is to be injected, and which DXC (1,2,3) is to be used.
>>
>> Interestingly, some support FP instructions are considered as HFP
>> instructions (I assume simply because they were available very early).
>>
>> Reviewed-by: Richard Henderson <address@hidden>
>> Signed-off-by: David Hildenbrand <address@hidden>
>> ---
>> target/s390x/insn-data.def | 254 ++++++++++++++++++-------------------
>> target/s390x/translate.c | 8 ++
>> 2 files changed, 135 insertions(+), 127 deletions(-)
> [...]
>> +/* Instruction flags */
>> +#define IF_HFP1 0x0001 /* r1 points at fp reg for HFP instructions
>> */
>> +#define IF_HFP2 0x0002 /* r2 points at fp reg for HFP instructions
>> */
>> +#define IF_HFP3 0x0004 /* r3 points at fp reg for HFP instructions
>> */
>
> I wonder if this would be less confusing if you'd call the constants
> IF_AFP[123] instead of IF_HFP[123] ? At least that's how DXC1 is called
> in my version of the PoP (DXC1 = "AFP register", and not "HFP
> instruction", while DXC2 is called "BFP instruction").
>
Yes, that most probably makes sense.
"HFP or FPS instruction"
--
Thanks,
David / dhildenb
- [qemu-s390x] [PATCH v3 1/9] s390x: move tcg_s390_program_interrupt() into TCG code and mark it noreturn, (continued)
- [qemu-s390x] [PATCH v3 1/9] s390x: move tcg_s390_program_interrupt() into TCG code and mark it noreturn, David Hildenbrand, 2018/09/17
- [qemu-s390x] [PATCH v3 2/9] s390x/tcg: factor out and fix DATA exception injection, David Hildenbrand, 2018/09/17
- [qemu-s390x] [PATCH v3 3/9] s390x/tcg: store in the TB flags if AFP is enabled, David Hildenbrand, 2018/09/17
- [qemu-s390x] [PATCH v3 4/9] s390x/tcg: support flags for instructions, David Hildenbrand, 2018/09/17
- [qemu-s390x] [PATCH v3 5/9] s390x/tcg: add instruction flags for floating point instructions, David Hildenbrand, 2018/09/17
- [qemu-s390x] [PATCH v3 6/9] s390x/tcg: check for AFP-register, BFP and DFP data exceptions, David Hildenbrand, 2018/09/17
- [qemu-s390x] [PATCH v3 8/9] s390x/tcg: fix FP register pair checks, David Hildenbrand, 2018/09/17
- [qemu-s390x] [PATCH v3 9/9] s390x/tcg: refactor specification checking, David Hildenbrand, 2018/09/17
- [qemu-s390x] [PATCH v3 7/9] s390x/tcg: handle privileged instructions via flags, David Hildenbrand, 2018/09/17