[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [Qemu-devel] [PATCH] tests: virtio: separate ccw tests

From: Cornelia Huck
Subject: Re: [qemu-s390x] [Qemu-devel] [PATCH] tests: virtio: separate ccw tests from libqos
Date: Wed, 1 Aug 2018 15:34:19 +0200

On Wed,  1 Aug 2018 15:27:33 +0200
Paolo Bonzini <address@hidden> wrote:

> Because qtest does not support s390 channel I/O, s390 only performs smoke 
> tests on
> those few devices that do not have any functional tests.  Therefore, every 
> time we
> add functional tests for a virtio device, the choice is between removing
> those tests from the s390 suite (so that s390 actually _loses_ coverage)
> or sprinkling the test with architecture checks.
> This patch simply creates a ccw-specific test that only performs smoke tests 
> on
> all virtio-ccw devices.  If channel I/O support is ever added to qtest and 
> libqos,
> then this file can go away.  In the meanwhile, it simplifies maintenance and
> makes sure that all virtio devices are tested.
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  tests/Makefile.include  |   5 +-
>  tests/virtio-ccw-test.c | 118 ++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 120 insertions(+), 3 deletions(-)
>  create mode 100644 tests/virtio-ccw-test.c

I'm not that familiar with qtest/libqos, but that sounds like a
reasonable approach.

Acked-by: Cornelia Huck <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]