[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v4 07/14] spapr: route all memory devices throug
|
From: |
David Hildenbrand |
|
Subject: |
Re: [qemu-s390x] [PATCH v4 07/14] spapr: route all memory devices through the machine hotplug handler |
|
Date: |
Tue, 5 Jun 2018 09:51:59 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05.06.2018 03:09, David Gibson wrote:
> On Thu, May 17, 2018 at 10:15:20AM +0200, David Hildenbrand wrote:
>> Necessary to hotplug them cleanly later.
>>
>> Signed-off-by: David Hildenbrand <address@hidden>
>
> As for PC, I think it would be nicer to drop the explicit check
> against PC_DIMM, since it is covered by MEMORY_DEVICE.
Indeed, already did that.
>
>> ---
>> hw/ppc/spapr.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
>> index b7c5c95f7a..2f315f963b 100644
>> --- a/hw/ppc/spapr.c
>> +++ b/hw/ppc/spapr.c
>> @@ -3666,6 +3666,7 @@ static HotplugHandler
>> *spapr_get_hotplug_handler(MachineState *machine,
>> DeviceState *dev)
>> {
>> if (object_dynamic_cast(OBJECT(dev), TYPE_PC_DIMM) ||
>> + object_dynamic_cast(OBJECT(dev), TYPE_MEMORY_DEVICE) ||
>> object_dynamic_cast(OBJECT(dev), TYPE_SPAPR_CPU_CORE)) {
>> return HOTPLUG_HANDLER(machine);
>> }
>
--
Thanks,
David / dhildenb