qemu-s390x
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [PATCH v2 for-2.13] pc-bios/s390-ccw: size_t should be


From: Thomas Huth
Subject: Re: [qemu-s390x] [PATCH v2 for-2.13] pc-bios/s390-ccw: size_t should be unsigned
Date: Mon, 23 Apr 2018 14:07:03 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0

On 23.04.2018 12:08, Cornelia Huck wrote:
> On Mon, 16 Apr 2018 09:45:20 +0200
> Thomas Huth <address@hidden> wrote:
> 
>> "size_t" should be an unsigned type according to the C standard.
>> Thus we should also use this convention in the s390-ccw firmware to avoid
>> confusion. I checked the sources, and apart from one spot in libc.c, the
>> code should all be fine with this change.
>>
>> Buglink: https://bugs.launchpad.net/qemu/+bug/1753437
>> Signed-off-by: Thomas Huth <address@hidden>
>> ---
>>  v2: Use long instead of ssize_t in uitoa()
>>
>>  pc-bios/s390-ccw/libc.c | 2 +-
>>  pc-bios/s390-ccw/libc.h | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> Reviewed-by: Cornelia Huck <address@hidden>
> 
> I assume you'll queue this one yourself?

Yes, I'll queue it with the other pending s390-ccw bios patches.

 Thomas



reply via email to

[Prev in Thread] Current Thread [Next in Thread]