Re: [qemu-s390x] [PATCH 1/3] target/s390x: convert to DisasJumpType

[David Hildenbrand]

>      switch (status) {
> -    case EXIT_GOTO_TB:
> -    case EXIT_NORETURN:
> +    case DISAS_GOTO_TB:
> +    case DISAS_NORETURN:
>          break;
> -    case EXIT_PC_STALE:
> -    case EXIT_PC_STALE_NOCHAIN:
> +    case DISAS_TOO_MANY:
> +    case DISAS_PC_STALE:
> +    case DISAS_PC_STALE_NOCHAIN:
>          update_psw_addr(&dc);


Not sure if this is really the right thing to do for DISAS_TOO_MANY but
it seems to work for now :)

>          /* FALLTHRU */
> -    case EXIT_PC_UPDATED:
> +    case DISAS_PC_UPDATED:
>          /* Next TB starts off with CC_OP_DYNAMIC, so make sure the
>             cc op type is in env */
>          update_cc_op(&dc);
>          /* FALLTHRU */
> -    case EXIT_PC_CC_UPDATED:
> +    case DISAS_PC_CC_UPDATED:
>          /* Exit the TB, either by raising a debug exception or by return.  */
>          if (do_debug) {
>              gen_exception(EXCP_DEBUG);
> -        } else if (use_exit_tb(&dc) || status == EXIT_PC_STALE_NOCHAIN) {
> +        } else if (use_exit_tb(&dc) || status == DISAS_PC_STALE_NOCHAIN) {
>              tcg_gen_exit_tb(0);
>          } else {
>              tcg_gen_lookup_and_goto_ptr();
> 

Reviewed-by: David Hildenbrand <address@hidden>

-- 

Thanks,

David / dhildenb