[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v1] cpus: make pause_all_cpus() play with SMP on
|
From: |
David Hildenbrand |
|
Subject: |
Re: [qemu-s390x] [PATCH v1] cpus: make pause_all_cpus() play with SMP on single threaded TCG |
|
Date: |
Mon, 11 Dec 2017 17:40:09 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
> int vm_stop(RunState state)
> {
> if (qemu_in_vcpu_thread()) {
> @@ -1818,7 +1809,8 @@ int vm_stop(RunState state)
> * FIXME: should not return to device code in case
> * vm_stop() has been requested.
> */
> - cpu_stop_current();
> + qemu_cpu_stop(current_cpu);
> + cpu_exit(current_cpu);
We're doing the cpu_exit() now after the broadcast, is this ok?
Also we drop the check for current_cpu, I assume this is also ok.
> return 0;
> }
>
--
Thanks,
David / dhildenb