[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v2 for-2.12 01/10] s390x/tcg: ASI/ASGI are atomi
From: |
Richard Henderson |
Subject: |
Re: [qemu-s390x] [PATCH v2 for-2.12 01/10] s390x/tcg: ASI/ASGI are atomic with interlocked-acccess facility 1 |
Date: |
Thu, 7 Dec 2017 15:41:34 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 12/07/2017 08:53 AM, David Hildenbrand wrote:
> +static ExitStatus op_asi(DisasContext *s, DisasOps *o)
> +{
> + o->in1 = tcg_temp_new_i64();
> + /* Perform the atomic addition in memory. */
> + tcg_gen_atomic_fetch_add_i64(o->in1, o->addr1, o->in2, get_mem_index(s),
> + s->insn->data);
> + /* However, we need to recompute the addition for setting CC. */
> + tcg_gen_add_i64(o->out, o->in1, o->in2);
> + return NO_EXIT;
> +}
Is it worth conditionalizing the atomic operation on having
interlocked-access-facility-1 enabled?
r~
- [qemu-s390x] [PATCH v2 for-2.12 00/10] s390x/tcg: facilitites and instructions, David Hildenbrand, 2017/12/07
- [qemu-s390x] [PATCH v2 for-2.12 01/10] s390x/tcg: ASI/ASGI are atomic with interlocked-acccess facility 1, David Hildenbrand, 2017/12/07
- Re: [qemu-s390x] [PATCH v2 for-2.12 01/10] s390x/tcg: ASI/ASGI are atomic with interlocked-acccess facility 1,
Richard Henderson <=
- [qemu-s390x] [PATCH v2 for-2.12 02/10] s390x/tcg: ALSI/ALSGI are atomic with interlocked-acccess facility 1, David Hildenbrand, 2017/12/07
- [qemu-s390x] [PATCH v2 for-2.12 03/10] s390x/tcg: implement Interlocked-Access Facility 2, David Hildenbrand, 2017/12/07
- [qemu-s390x] [PATCH v2 for-2.12 04/10] s390x/tcg: wire up SET ADDRESS LIMIT, David Hildenbrand, 2017/12/07
- [qemu-s390x] [PATCH v2 for-2.12 05/10] s390x/tcg: wire up SET CHANNEL MONITOR, David Hildenbrand, 2017/12/07