[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v2 for-2.12 02/16] s390x/tcg: get rid of runtime
From: |
David Hildenbrand |
Subject: |
Re: [qemu-s390x] [PATCH v2 for-2.12 02/16] s390x/tcg: get rid of runtime_exception() |
Date: |
Thu, 30 Nov 2017 16:56:47 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 30.11.2017 10:10, Thomas Huth wrote:
> On 29.11.2017 21:26, David Hildenbrand wrote:
>> Let's use s390_program_interrupt() instead.
>>
>> Reviewed-by: Richard Henderson <address@hidden>
>> Signed-off-by: David Hildenbrand <address@hidden>
>> ---
>> target/s390x/fpu_helper.c | 2 +-
>> target/s390x/int_helper.c | 14 +++++++-------
>> target/s390x/internal.h | 2 --
>> target/s390x/misc_helper.c | 16 ----------------
>> 4 files changed, 8 insertions(+), 26 deletions(-)
>
> Is it a disadvantage that runtime_exception() was declared as
> QEMU_NORETURN, and s390_program_interrupt() is not declared as
> QEMU_NORETURN?
We could add that to trigger_pgm_exception instead. But if
cpu_loop_exit() would really return, we would be in more trouble AKA
nothing would work.
So I don't see a problem dropping this.
>
> At a first glance, I guess it's ok, and in that case:
>
> Reviewed-by: Thomas Huth <address@hidden>
>
--
Thanks,
David / dhildenb
- [qemu-s390x] [PATCH v2 for-2.12 00/16] s390x/tcg: cleanup and fix program interrupts, David Hildenbrand, 2017/11/29
- [qemu-s390x] [PATCH v2 for-2.12 02/16] s390x/tcg: get rid of runtime_exception(), David Hildenbrand, 2017/11/29
- [qemu-s390x] [PATCH v2 for-2.12 01/16] s390x/tcg: introduce and use s390_program_interrupt(), David Hildenbrand, 2017/11/29
- [qemu-s390x] [PATCH v2 for-2.12 03/16] s390x/tcg: rip out dead tpi code, David Hildenbrand, 2017/11/29
- [qemu-s390x] [PATCH v2 for-2.12 04/16] s390x/ioinst: pass the retaddr to all IO instructions, David Hildenbrand, 2017/11/29
- [qemu-s390x] [PATCH v2 for-2.12 06/16] s390x/diag: pass the retaddr into handle_diag_308(), David Hildenbrand, 2017/11/29
- [qemu-s390x] [PATCH v2 for-2.12 05/16] s390x/pci: pass the retaddr to all PCI instructions, David Hildenbrand, 2017/11/29
- [qemu-s390x] [PATCH v2 for-2.12 08/16] s390x/tcg: don't exit the cpu loop in s390_cpu_virt_mem_rw(), David Hildenbrand, 2017/11/29