[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v1 for-2.12 07/15] s390x: handle exceptions duri
From: |
David Hildenbrand |
Subject: |
Re: [qemu-s390x] [PATCH v1 for-2.12 07/15] s390x: handle exceptions during s390_cpu_virt_mem_rw() correctly (TCG) |
Date: |
Wed, 29 Nov 2017 17:25:02 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 29.11.2017 16:59, Cornelia Huck wrote:
> On Wed, 29 Nov 2017 16:54:30 +0100
> David Hildenbrand <address@hidden> wrote:
>
>
>>>> diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c
>>>> index 31e3f3f415..39da9aeef4 100644
>>>> --- a/target/s390x/mmu_helper.c
>>>> +++ b/target/s390x/mmu_helper.c
>>>> @@ -22,6 +22,7 @@
>>>> #include "internal.h"
>>>> #include "kvm_s390x.h"
>>>> #include "sysemu/kvm.h"
>>>> +#include "exec/exec-all.h"
>>>> #include "trace.h"
>>>> #include "hw/s390x/storage-keys.h"
>>>>
>>>> @@ -458,7 +459,7 @@ static int translate_pages(S390CPU *cpu, vaddr addr,
>>>> int nr_pages,
>>>> }
>>>> if (!address_space_access_valid(&address_space_memory, pages[i],
>>>> TARGET_PAGE_SIZE, is_write)) {
>>>> - program_interrupt(env, PGM_ADDRESSING, ILEN_AUTO);
>>>> + trigger_pgm_exception(env, PGM_ADDRESSING, ILEN_AUTO);
>>>
>>> Why did you change this?
>>
>> "For TCG, there was one case where a cpu loop exit was triggered. Fix
>> that up."
>>
>> Wasn't worth a separate patch :)
>
> Well, maybe it is, to avoid dumb questions :)
... splitting it up :) Thanks!
--
Thanks,
David / dhildenb
[qemu-s390x] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions, David Hildenbrand, 2017/11/28
- Re: [qemu-s390x] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions, Cornelia Huck, 2017/11/29
- Re: [qemu-s390x] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions, David Hildenbrand, 2017/11/29
- Re: [qemu-s390x] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions, Cornelia Huck, 2017/11/29
- Re: [qemu-s390x] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions, David Hildenbrand, 2017/11/29
- Re: [qemu-s390x] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions, Cornelia Huck, 2017/11/29
- Re: [qemu-s390x] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions, David Hildenbrand, 2017/11/29
- Re: [qemu-s390x] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions, Cornelia Huck, 2017/11/29
- Re: [qemu-s390x] [PATCH v1 for-2.12 04/15] s390x/ioinst: pass the retaddr to all IO instructions, David Hildenbrand, 2017/11/29