[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [Qemu-devel] [PATCH for-2.11] hw/net/vmxnet3: Fix code
|
From: |
Thomas Huth |
|
Subject: |
Re: [qemu-s390x] [Qemu-devel] [PATCH for-2.11] hw/net/vmxnet3: Fix code to work on big endian hosts, too |
|
Date: |
Mon, 13 Nov 2017 21:23:22 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 13.11.2017 18:09, address@hidden wrote:
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
[...]
> === OUTPUT BEGIN ===
> Checking PATCH 1/1: hw/net/vmxnet3: Fix code to work on big endian hosts,
> too...
> ERROR: spaces required around that ':' (ctx:VxV)
> #202: FILE: hw/net/vmxnet3.h:232:
> + u32 msscof:14; /* MSS, checksum offset, flags */
FWIW, these are definitely false warnings: If I change the patch to use
spaces around ":" everywhere in the bitfields, checkpatch complains
instead that the spaces should be removed!
Thomas
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [qemu-s390x] [Qemu-devel] [PATCH for-2.11] hw/net/vmxnet3: Fix code to work on big endian hosts, too,
Thomas Huth <=