Re: [PATCH 2/5] rust: pl011: move register definitions out of lib.rs

[Paolo Bonzini]

On 2/27/25 18:28, Peter Maydell wrote:
> On Thu, 27 Feb 2025 at 16:48, Paolo Bonzini <pbonzini@redhat.com> wrote:
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> >   rust/hw/char/pl011/src/device.rs    |   7 +-
> >   rust/hw/char/pl011/src/lib.rs       | 509 +---------------------------
> >   rust/hw/char/pl011/src/registers.rs | 507 +++++++++++++++++++++++++++
> >   3 files changed, 513 insertions(+), 510 deletions(-)
> >   create mode 100644 rust/hw/char/pl011/src/registers.rs
>
> Looking at this patch I'm sorely tempted to suggest significantly
> trimming down the commentary in these comments: it contains
> rather more text cut-n-pasted from the PL011 TRM than I'm
> entirely comfortable with, and much of it is detail that
> is irrelevant to QEMU.

Yeah, that was a point that was made on the call last week, too.  I kind 
of agree, but it wasn't a decision I really wanted to take or suggest.

Also, some of the stuff does not belong in the structs but could be 
added to lib.rs, too, with more fair-use justification than in 
registers.rs.  So perhaps delay removing it until more aspects of the 
FIFO are modeled correctly, so that one does not have to reinvent the 
wording from scratch.

Paolo