Re: [PATCH] include virtualization mode as part of priv

[Daniel Henrique Barboza]

On 11/28/24 3:39 AM, Yanfeng wrote:
> On Thu, 2024-11-28 at 14:46 +1000, Alistair Francis wrote:
> > On Thu, Nov 28, 2024 at 2:27 PM Yanfeng <yfliu2008@qq.com> wrote:
> > > On Thu, 2024-11-28 at 14:10 +1000, Alistair Francis wrote:
> > > > On Thu, Nov 28, 2024 at 2:05 PM Yanfeng <yfliu2008@qq.com> wrote:
> > > > > Alistair.
> > > > >
> > > > > My initial `git send-email" on Ubuntu 22.04 wasn't lukcy:
> > > > >
> > > > > ```shell
> > > > > $ git send-email
> > > > > git: 'send-email' is not a git command. See 'git --help'.
> > > > > ```
> > > > >
> > > > > I need time to find a solution.
> > > >
> > > > You will need to install git-send-email (or something like that)
> > >
> > > Yes, now the "git send-email" exists and I will see how to use it correctly.
> > >
> > > > > As for seperate `virt` thing, my concern is that though the V and P
> > > > > status
> > > > > looks
> > > > > orthogonal, they are not so independent (e.g. `P=3` implies `V=0`).
> > > > > Having
> > > > > them
> > > > > in one `priv` register tells user that that they should be operated
> > > > > together
> > > > > using one command.
> > > >
> > > > True, but how can a user know what bit 8 means?
> > >
> > > Good point. Can we mention it in the user document for `priv` register?
> >
> > AFAIK we don't really have a place to document that. Which is why a
> > "virt" register would help as it's self documenting.
>
> Okay, I will try adding a `virt` virtual register in a [PATCH v2] later.

Can you please also change the patch title/subject to:

"riscv: include virtualization mode as part of priv"

Adding 'riscv' at the beginning will help people from the common qemu-devel ML 
to
identify which subsystem/arch this patch is aimed at.


Thanks,

Daniel



> > Alistair
> >
> > > I used bit(8) at my first try and it worked from GDB command line. Actually
> > > I
> > > also tried bit(4) but found GDB command takes that bit as part of P value so
> > > I
> > > withdrawed back to bit(8).