[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH for-10.0 v2 2/8] hw/riscv/virt.c: reduce virt_use_kvm_aia() usage
From: |
Daniel Henrique Barboza |
Subject: |
[PATCH for-10.0 v2 2/8] hw/riscv/virt.c: reduce virt_use_kvm_aia() usage |
Date: |
Tue, 19 Nov 2024 16:17:00 -0300 |
In create_fdt_sockets() we have the following pattern:
if (kvm_enabled() && virt_use_kvm_aia(s)) {
(... do stuff ...)
} else {
(... do other stuff ...)
}
if (kvm_enabled() && virt_use_kvm_aia(s)) {
(... do more stuff ...)
} else {
(... do more other stuff)
}
Do everything in a single if/else clause to reduce the usage of
virt_use_kvm_aia() helper and to make the code a bit less repetitive.
Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
---
hw/riscv/virt.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
index 45a8c4f819..e200fc561a 100644
--- a/hw/riscv/virt.c
+++ b/hw/riscv/virt.c
@@ -781,6 +781,10 @@ static void create_fdt_sockets(RISCVVirtState *s, const
MemMapEntry *memmap,
msi_m_phandle, msi_s_phandle, phandle,
&intc_phandles[0], xplic_phandles,
ms->smp.cpus);
+
+ *irq_mmio_phandle = xplic_phandles[0];
+ *irq_virtio_phandle = xplic_phandles[0];
+ *irq_pcie_phandle = xplic_phandles[0];
} else {
phandle_pos = ms->smp.cpus;
for (socket = (socket_count - 1); socket >= 0; socket--) {
@@ -798,13 +802,7 @@ static void create_fdt_sockets(RISCVVirtState *s, const
MemMapEntry *memmap,
s->soc[socket].num_harts);
}
}
- }
- if (kvm_enabled() && virt_use_kvm_aia(s)) {
- *irq_mmio_phandle = xplic_phandles[0];
- *irq_virtio_phandle = xplic_phandles[0];
- *irq_pcie_phandle = xplic_phandles[0];
- } else {
for (socket = 0; socket < socket_count; socket++) {
if (socket == 0) {
*irq_mmio_phandle = xplic_phandles[socket];
--
2.47.0
- [PATCH for-10.0 v2 0/8] riscv: AIA userspace irqchip_split support, Daniel Henrique Barboza, 2024/11/19
- [PATCH for-10.0 v2 1/8] hw/intc/riscv_aplic: rename is_kvm_aia(), Daniel Henrique Barboza, 2024/11/19
- [PATCH for-10.0 v2 3/8] hw/riscv/virt.c: rename helper to virt_use_kvm_aia_aplic_imsic(), Daniel Henrique Barboza, 2024/11/19
- [PATCH for-10.0 v2 2/8] hw/riscv/virt.c: reduce virt_use_kvm_aia() usage,
Daniel Henrique Barboza <=
- [PATCH for-10.0 v2 4/8] target/riscv/kvm: consider irqchip_split() in aia_create(), Daniel Henrique Barboza, 2024/11/19
- [PATCH for-10.0 v2 5/8] hw/riscv/virt.c, riscv_aplic.c: add 'emulated_aplic' helpers, Daniel Henrique Barboza, 2024/11/19
- [PATCH for-10.0 v2 6/8] hw/intc/riscv_aplic: add kvm_msicfgaddr for split mode aplic-imsic, Daniel Henrique Barboza, 2024/11/19
- [PATCH for-10.0 v2 7/8] target/riscv/kvm: remove irqchip_split() restriction, Daniel Henrique Barboza, 2024/11/19
- [PATCH for-10.0 v2 8/8] docs: update riscv/virt.rst with kernel-irqchip=split support, Daniel Henrique Barboza, 2024/11/19
- Re: [PATCH for-10.0 v2 0/8] riscv: AIA userspace irqchip_split support, Alistair Francis, 2024/11/20