Re: [PATCH v2] hw/riscv: fix build error with clang

[Daniel Henrique Barboza]

On 11/5/24 7:55 PM, Philippe Mathieu-Daudé wrote:
> On 5/11/24 05:29, Pierrick Bouvier wrote:
> > Thanks for the review.
> > Feel free to pull the patch in your next PR, so it can be available for release 
> > 9.2.
> >
> > Regards,
> > Pierrick
> >
> > On 11/4/24 18:37, Alistair Francis wrote:
> > > On Tue, Nov 5, 2024 at 8:23 AM Pierrick Bouvier
> > > <pierrick.bouvier@linaro.org> wrote:
> > > > Introduced in 0c54ac, "hw/riscv: add RISC-V IOMMU base emulation"
> > > >
> > > > ../hw/riscv/riscv-iommu.c:187:17: error: redefinition of '_pext_u64'
> > > >
> > > >    187 | static uint64_t _pext_u64(uint64_t val, uint64_t ext)
> > > >
> > > >        |                 ^
> > > >
> > > > D:/a/_temp/msys64/clang64/lib/clang/18/include/bmi2intrin.h:217:1: note: 
> > > > previous definition is here
> > > >
> > > >    217 | _pext_u64(unsigned long long __X, unsigned long long __Y)
> > > >
> > > >        | ^
> > > >
> > > > After a conversation on the mailing list, it was decided to rename and
> > > > add a comment for this function.
> > > >
> > > > Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> > >
> > > Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
>
> Fix queued via hw-misc tree.

Do you fancy taking the riscv-iommu Coverity fixes as well? They're somewhat 
trivial and it'll
spare Alistair from making a PR with just a handful of patches.


Thanks,

Daniel