Re: [PATCH 3/4] target/riscv: Encode the FS and VS on a normal way for tb flags

[Richard Henderson]

On 3/23/23 22:59, LIU Zhiwei wrote:
> Reuse the MSTATUS_FS and MSTATUS_VS for the tb flags positions is not a normal
> way.
>
> It will make us change the tb flags layout difficult. And even worse, if we
> want to keep tb flags for a same extension togather without a hole.
>
> Signed-off-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


> +    flags =  FIELD_DP32(flags, TB_FLAGS, FS, EXT_STATUS_DIRTY);
> +    flags =  FIELD_DP32(flags, TB_FLAGS, VS, EXT_STATUS_DIRTY);
...
> +        flags =  FIELD_DP32(flags, TB_FLAGS, FS,
...
> +        flags =  FIELD_DP32(flags, TB_FLAGS, VS,

Extra space after =.


r~