[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 24/70] target/m68k: Reject immediate as destination in gen_ea_mod
From: |
Richard Henderson |
Subject: |
[PATCH 24/70] target/m68k: Reject immediate as destination in gen_ea_mode |
Date: |
Sun, 26 Feb 2023 19:41:47 -1000 |
In theory this should never happen, as all such instructions
are illegal. This is checked in e.g. gen_lea_mode and
gen_ea_mode_fp but not here. In case something higher up
isn't checking modes properly, return NULL_QREG. This will
result in an illegal instruction exception being raised.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/m68k/translate.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/target/m68k/translate.c b/target/m68k/translate.c
index 3055d2d246..7a87811427 100644
--- a/target/m68k/translate.c
+++ b/target/m68k/translate.c
@@ -898,6 +898,10 @@ static TCGv gen_ea_mode(CPUM68KState *env, DisasContext
*s, int mode, int reg0,
case 3: /* pc index+displacement. */
goto do_indirect;
case 4: /* Immediate. */
+ /* Should never be used for an output or RMW input. */
+ if (what == EA_STORE || addrp) {
+ return NULL_QREG;
+ }
/* Sign extend values for consistency. */
switch (opsize) {
case OS_BYTE:
--
2.34.1
- [PATCH 20/70] target/hppa: Avoid tcg_const_i64 in trans_fid_f, (continued)
- [PATCH 21/70] target/hppa: Avoid use of tcg_const_i32 throughout, Richard Henderson, 2023/02/27
- [PATCH 22/70] target/i386: Simplify POPF, Richard Henderson, 2023/02/27
- [PATCH 25/70] target/m68k: Use tcg_constant_i32 in gen_ea_mode, Richard Henderson, 2023/02/27
- [PATCH 23/70] target/i386: Avoid use of tcg_const_* throughout, Richard Henderson, 2023/02/27
- [PATCH 24/70] target/m68k: Reject immediate as destination in gen_ea_mode,
Richard Henderson <=
- [PATCH 26/70] target/m68k: Avoid tcg_const_i32 when modified, Richard Henderson, 2023/02/27
- [PATCH 27/70] target/m68k: Avoid tcg_const_i32 in bfop_reg, Richard Henderson, 2023/02/27
- [PATCH 30/70] target/mips: Split out gen_lxl, Richard Henderson, 2023/02/27
- [PATCH 28/70] target/m68k: Avoid tcg_const_* throughout, Richard Henderson, 2023/02/27
- [PATCH 29/70] target/microblaze: Avoid tcg_const_* throughout, Richard Henderson, 2023/02/27
- [PATCH 33/70] target/mips: Avoid tcg_const_* throughout, Richard Henderson, 2023/02/27
- [PATCH 31/70] target/mips: Split out gen_lxr, Richard Henderson, 2023/02/27
- [PATCH 32/70] target/mips: Avoid tcg_const_tl in gen_r6_ld, Richard Henderson, 2023/02/27
- [PATCH 34/70] target/ppc: Split out gen_vx_vmul10, Richard Henderson, 2023/02/27