|
From: | Daniel Henrique Barboza |
Subject: | Re: [PATCH v7 1/4] tcg: add 'size' param to probe_access_flags() |
Date: | Fri, 24 Feb 2023 06:20:22 -0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 |
On 2/23/23 21:23, Richard Henderson wrote:
On 2/23/23 14:19, Richard Henderson wrote:On 2/23/23 13:44, Daniel Henrique Barboza wrote:+ if (unlikely(flags & TLB_NOTDIRTY)) { + notdirty_write(env_cpu(env), addr, 1, full, retaddr);That '1' should be 'size'. Fixed locally.Hmph, well, that matches the interface, but it's only used to figure out how many pages to process, so any len that doesn't cross a page boundary (which we have checked) is equal bar the tracepoint.
I didn't touch that '1' because I figured it might not be related with how 'size' was going to be handled and any value > 0 would suffice. Thanks, Daniel
r~
[Prev in Thread] | Current Thread | [Next in Thread] |