[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] target/riscv: fix user-mode build issue because mhartid
|
From: |
Anup Patel |
|
Subject: |
Re: [PATCH v2] target/riscv: fix user-mode build issue because mhartid |
|
Date: |
Wed, 29 Jun 2022 10:00:43 +0530 |
On Wed, Jun 29, 2022 at 9:27 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> Hi Rahul,
>
> On Wed, Jun 29, 2022 at 10:07 AM Rahul Pathak <rpathak@ventanamicro.com>
> wrote:
> >
> > Hi Alistair
> >
> > My fix patch needs to be dropped since Anup took care of this issue
> > in his yesterdays series update in this patch -
> > [PATCH v8 4/4] target/riscv: Force disable extensions if priv spec
> > version does not match
>
> I don't understand. Each patch should keep bisectability.
The patches are already bisectable. There was a compile error until
v6 which was fixed in v7 by squashing this patch into PATCH4.
>
> This sounds like to me, that
> [PATCH v8 4/4] target/riscv: Force disable extensions if priv spec
> version does not match
>
> has an issue that it does 2 things: one is to fix this bug, and the
> other one is to force disable extensions.
>
> Which is not right.
The bug is fixed as a result of force disabling extensions which
don't match the priv spec version.
Regards,
Anup