[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 11/12] target/riscv: Implement virtual time adjusting with
From: |
Anup Patel |
Subject: |
Re: [PATCH v2 11/12] target/riscv: Implement virtual time adjusting with vm state changing |
Date: |
Mon, 13 Dec 2021 10:09:58 +0530 |
On Fri, Dec 10, 2021 at 3:38 PM Yifei Jiang <jiangyifei@huawei.com> wrote:
>
> We hope that virtual time adjusts with vm state changing. When a vm
> is stopped, guest virtual time should stop counting and kvm_timer
> should be stopped. When the vm is resumed, guest virtual time should
> continue to count and kvm_timer should be restored.
>
> Signed-off-by: Yifei Jiang <jiangyifei@huawei.com>
> Signed-off-by: Mingwang Li <limingwang@huawei.com>
Looks good to me.
Reviewed-by: Anup Patel <anup.patel@wdc.com>
Regards,
Anup
> ---
> target/riscv/kvm.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/target/riscv/kvm.c b/target/riscv/kvm.c
> index 802c076b22..be95dbc3f3 100644
> --- a/target/riscv/kvm.c
> +++ b/target/riscv/kvm.c
> @@ -40,6 +40,7 @@
> #include "kvm_riscv.h"
> #include "sbi_ecall_interface.h"
> #include "semihosting/console.h"
> +#include "sysemu/runstate.h"
>
> static uint64_t kvm_riscv_reg_id(CPURISCVState *env, uint64_t type, uint64_t
> idx)
> {
> @@ -377,6 +378,17 @@ unsigned long kvm_arch_vcpu_id(CPUState *cpu)
> return cpu->cpu_index;
> }
>
> +static void kvm_riscv_vm_state_change(void *opaque, bool running, RunState
> state)
> +{
> + CPUState *cs = opaque;
> +
> + if (running) {
> + kvm_riscv_put_regs_timer(cs);
> + } else {
> + kvm_riscv_get_regs_timer(cs);
> + }
> +}
> +
> void kvm_arch_init_irq_routing(KVMState *s)
> {
> }
> @@ -389,6 +401,8 @@ int kvm_arch_init_vcpu(CPUState *cs)
> CPURISCVState *env = &cpu->env;
> uint64_t id;
>
> + qemu_add_vm_change_state_handler(kvm_riscv_vm_state_change, cs);
> +
> id = kvm_riscv_reg_id(env, KVM_REG_RISCV_CONFIG,
> KVM_REG_RISCV_CONFIG_REG(isa));
> ret = kvm_get_one_reg(cs, id, &isa);
> if (ret) {
> --
> 2.19.1
>
- [PATCH v2 06/12] target/riscv: Support start kernel directly by KVM, (continued)
- [PATCH v2 06/12] target/riscv: Support start kernel directly by KVM, Yifei Jiang, 2021/12/10
- [PATCH v2 07/12] target/riscv: Support setting external interrupt by KVM, Yifei Jiang, 2021/12/10
- [PATCH v2 08/12] target/riscv: Handle KVM_EXIT_RISCV_SBI exit, Yifei Jiang, 2021/12/10
- [PATCH v2 09/12] target/riscv: Add host cpu type, Yifei Jiang, 2021/12/10
- [PATCH v2 11/12] target/riscv: Implement virtual time adjusting with vm state changing, Yifei Jiang, 2021/12/10
- Re: [PATCH v2 11/12] target/riscv: Implement virtual time adjusting with vm state changing,
Anup Patel <=
- [PATCH v2 10/12] target/riscv: Add kvm_riscv_get/put_regs_timer, Yifei Jiang, 2021/12/10
- [PATCH v2 12/12] target/riscv: Support virtual time context synchronization, Yifei Jiang, 2021/12/10