Re: [PATCH 06/13] target/riscv: Adjust vsetvl according to ol

qemu-riscv

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 06/13] target/riscv: Adjust vsetvl according to ol

From:	Richard Henderson
Subject:	Re: [PATCH 06/13] target/riscv: Adjust vsetvl according to ol
Date:	Mon, 1 Nov 2021 06:53:09 -0400
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 11/1/21 6:01 AM, LIU Zhiwei wrote:

--- a/target/riscv/insn_trans/trans_rvv.c.inc
+++ b/target/riscv/insn_trans/trans_rvv.c.inc
@@ -37,7 +37,7 @@ static bool trans_vsetvl(DisasContext *ctx, arg_vsetvl *a)
      } else {
          s1 = get_gpr(ctx, a->rs1, EXT_ZERO);
      }
-    gen_helper_vsetvl(dst, cpu_env, s1, s2);
+    gen_helper_vsetvl(dst, cpu_env, s1, s2, tcg_constant_tl(get_olen(ctx)));


XLEN not OLEN.

+        if (olen < TARGET_LONG_BITS) {
+            env->vtype = FIELD_DP64(0, VTYPE, VILL_OLEN32, 1);
+        } else {
+            env->vtype = FIELD_DP64(0, VTYPE, VILL, 1);
+        }

This looks like an excellent reason to split VILL out of VTYPE and create a separateenv->vill field. Re-assemble it when reading the CSR, much like we do for misa.mxl. Thatwould want to be a separate patch, of course.

r~

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH 09/13] target/riscv: Adjust vector address with ol, (continued)
- [PATCH 07/13] target/riscv: Ajdust vector atomic check with ol, LIU Zhiwei, 2021/11/01
  - Re: [PATCH 07/13] target/riscv: Ajdust vector atomic check with ol, Richard Henderson, 2021/11/01
- [PATCH 06/13] target/riscv: Adjust vsetvl according to ol, LIU Zhiwei, 2021/11/01
  - Re: [PATCH 06/13] target/riscv: Adjust vsetvl according to ol, Richard Henderson <=
- [PATCH 13/13] target/riscv: Enable uxl field write, LIU Zhiwei, 2021/11/01
  - Re: [PATCH 13/13] target/riscv: Enable uxl field write, Richard Henderson, 2021/11/01
    - Re: [PATCH 13/13] target/riscv: Enable uxl field write, LIU Zhiwei, 2021/11/08
    - Re: [PATCH 13/13] target/riscv: Enable uxl field write, LIU Zhiwei, 2021/11/09
- [PATCH 10/13] target/riscv: Adjust scalar reg in vector with ol, LIU Zhiwei, 2021/11/01
  - Re: [PATCH 10/13] target/riscv: Adjust scalar reg in vector with ol, Richard Henderson, 2021/11/01
    - Re: [PATCH 10/13] target/riscv: Adjust scalar reg in vector with ol, LIU Zhiwei, 2021/11/08
- [PATCH 08/13] target/riscv: Fix check range for first fault only, LIU Zhiwei, 2021/11/01
  - Re: [PATCH 08/13] target/riscv: Fix check range for first fault only, Richard Henderson, 2021/11/01

Prev by Date: Re: [PATCH 05/13] target/riscv: Calculate address according to ol
Next by Date: Re: [PATCH 07/13] target/riscv: Ajdust vector atomic check with ol
Previous by thread: [PATCH 06/13] target/riscv: Adjust vsetvl according to ol
Next by thread: [PATCH 13/13] target/riscv: Enable uxl field write
Index(es):
- Date
- Thread