[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/5] hw/riscv: virt: Don't use a macro for the PLIC config
|
From: |
Bin Meng |
|
Subject: |
Re: [PATCH v2 1/5] hw/riscv: virt: Don't use a macro for the PLIC configuration |
|
Date: |
Fri, 22 Oct 2021 21:44:49 +0800 |
On Fri, Oct 22, 2021 at 6:38 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> On 10/22/21 08:01, Alistair Francis wrote:
> > From: Alistair Francis <alistair.francis@wdc.com>
> >
> > Using a macro for the PLIC configuration doesn't make the code any
> > easier to read. Instead it makes it harder to figure out what is going
> > on, so let's remove it.
> >
> > Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> > ---
> > include/hw/riscv/virt.h | 1 -
> > hw/riscv/virt.c | 2 +-
> > 2 files changed, 1 insertion(+), 2 deletions(-)
>
> No cover letter, so using the first patch.
It's also better to include a changelog in each patch otherwise it's
hard to track what has changed compared to v1, especially the v1 was
posted 1.5 months ago.
>
> Series:
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Regards,
Bin
- [PATCH v2 1/5] hw/riscv: virt: Don't use a macro for the PLIC configuration, Alistair Francis, 2021/10/22
- [PATCH v2 2/5] hw/riscv: boot: Add a PLIC config string function, Alistair Francis, 2021/10/22
- [PATCH v2 3/5] hw/riscv: sifive_u: Use the PLIC config helper function, Alistair Francis, 2021/10/22
- [PATCH v2 4/5] hw/riscv: microchip_pfsoc: Use the PLIC config helper function, Alistair Francis, 2021/10/22
- [PATCH v2 5/5] hw/riscv: virt: Use the PLIC config helper function, Alistair Francis, 2021/10/22
- Re: [PATCH v2 1/5] hw/riscv: virt: Don't use a macro for the PLIC configuration, Philippe Mathieu-Daudé, 2021/10/22
- Re: [PATCH v2 1/5] hw/riscv: virt: Don't use a macro for the PLIC configuration,
Bin Meng <=