[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 16/53] target/microblaze: convert to use format_state inst
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v2 16/53] target/microblaze: convert to use format_state instead of dump_state |
|
Date: |
Wed, 15 Sep 2021 09:23:10 +0200 |
On Wed, Sep 15, 2021 at 9:21 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> On 9/15/21 9:18 AM, Philippe Mathieu-Daudé wrote:
> > On 9/14/21 4:20 PM, Daniel P. Berrangé wrote:
> >> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> >> ---
> >> target/microblaze/cpu.c | 2 +-
> >> target/microblaze/cpu.h | 2 +-
> >> target/microblaze/translate.c | 45 ++++++++++++++++++-----------------
> >> 3 files changed, 25 insertions(+), 24 deletions(-)
> >
> >> for (i = 0; i < 32; i++) {
> >> - qemu_fprintf(f, "r%2.2d=%08x%c",
> >> - i, env->regs[i], i % 4 == 3 ? '\n' : ' ');
> >> + g_string_append_printf(buf, "r%2.2d=%08x%c",
> >> + i, env->regs[i], i % 4 == 3 ? '\n' : ' ');
> >> }
> >> - qemu_fprintf(f, "\n");
> >> + g_string_append_printf(buf, "\n");
> >
> > g_string_append_c(), otherwise:
>
> Actually we don't need an extra newline.
Oops sorry here we do.
> > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> >
> >> }
> >>
> >> void mb_tcg_init(void)
> >>
> >
- Re: [PATCH v2 12/53] target/hexagon: convert to use format_state instead of dump_state, (continued)
- [PATCH v2 17/53] target/mips: convert to use format_state instead of dump_state, Daniel P . Berrangé, 2021/09/14
- [PATCH v2 18/53] target/nios2: convert to use format_state instead of dump_state, Daniel P . Berrangé, 2021/09/14
- [PATCH v2 19/53] target/openrisc: convert to use format_state instead of dump_state, Daniel P . Berrangé, 2021/09/14
- [PATCH v2 20/53] target/ppc: convert to use format_state instead of dump_state, Daniel P . Berrangé, 2021/09/14
- [PATCH v2 21/53] target/riscv: convert to use format_state instead of dump_state, Daniel P . Berrangé, 2021/09/14