Re: [PATCH v2 11/12] hw/isa/vt82c686: Add missing Kconfig dependency (runtime error)

[Bin Meng]

On Sun, May 16, 2021 at 1:46 AM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
>
> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> When building the Pegasos2 machine stand-alone we get:
>
>   $ qemu-system-ppc -M pegasos2 -bios pegasos2.rom
>   ERROR:qom/object.c:714:object_new_with_type: assertion failed: (type != 
> NULL)
>   Bail out! ERROR:qom/object.c:714:object_new_with_type: assertion failed: 
> (type != NULL)
>
> Looking at the backtrace:
>
>   Thread 1 "qemu-system-ppc" received signal SIGABRT, Aborted.
>   (gdb) bt
>   #0  0x00007ffff53877d5 in raise () at /lib64/libc.so.6
>   #1  0x00007ffff5370895 in abort () at /lib64/libc.so.6
>   #2  0x00007ffff6dc4b6c in g_assertion_message_expr.cold () at 
> /lib64/libglib-2.0.so.0
>   #3  0x00007ffff6e229ff in g_assertion_message_expr () at 
> /lib64/libglib-2.0.so.0
>   #4  0x0000555555a0c8f4 in object_new_with_type (type=0x0) at 
> qom/object.c:714
>   #5  0x0000555555a0c9d5 in object_new (typename=0x555555c7afe4 "isa-pit") at 
> qom/object.c:747
>   #6  0x0000555555a053b8 in qdev_new (name=0x555555c7afe4 "isa-pit") at 
> hw/core/qdev.c:153
>   #7  0x00005555557cdd05 in isa_new (name=0x555555c7afe4 "isa-pit") at 
> hw/isa/isa-bus.c:160
>   #8  0x00005555557cf518 in i8254_pit_init (bus=0x55555603d140, base=64, 
> isa_irq=0, alt_irq=0x0) at include/hw/timer/i8254.h:54
>   #9  0x00005555557d12f9 in vt8231_realize (d=0x5555563d9770, 
> errp=0x7fffffffcc28) at hw/isa/vt82c686.c:704
>   #10 0x00005555557e1340 in pci_qdev_realize (qdev=0x5555563d9770, 
> errp=0x7fffffffcca0) at hw/pci/pci.c:2116
>   #11 0x0000555555a06a84 in device_set_realized (obj=0x5555563d9770, 
> value=true, errp=0x7fffffffcda8) at hw/core/qdev.c:761
>   #12 0x0000555555a0ff9e in property_set_bool (obj=0x5555563d9770, 
> v=0x5555563da090, name=0x555555cd7881 "realized", opaque=0x5555560acf80, 
> errp=0x7fffffffcda8) at qom/object.c:2257
>   #13 0x0000555555a0e098 in object_property_set (obj=0x5555563d9770, 
> name=0x555555cd7881 "realized", v=0x5555563da090, errp=0x555555fc3fa0 
> <error_fatal>) at qom/object.c:1402
>   #14 0x0000555555a12271 in object_property_set_qobject (obj=0x5555563d9770, 
> name=0x555555cd7881 "realized", value=0x5555563cf0a0, errp=0x555555fc3fa0 
> <error_fatal>) at qom/qom-qobject.c:28
>   #15 0x0000555555a0e3fb in object_property_set_bool (obj=0x5555563d9770, 
> name=0x555555cd7881 "realized", value=true, errp=0x555555fc3fa0 
> <error_fatal>) at qom/object.c:1472
>   #16 0x0000555555a05b15 in qdev_realize (dev=0x5555563d9770, 
> bus=0x5555563d32b0, errp=0x555555fc3fa0 <error_fatal>) at hw/core/qdev.c:389
>   #17 0x0000555555a05b42 in qdev_realize_and_unref (dev=0x5555563d9770, 
> bus=0x5555563d32b0, errp=0x555555fc3fa0 <error_fatal>) at hw/core/qdev.c:396
>   #18 0x00005555557e160f in pci_realize_and_unref (dev=0x5555563d9770, 
> bus=0x5555563d32b0, errp=0x555555fc3fa0 <error_fatal>) at hw/pci/pci.c:2181
>   #19 0x00005555557e165b in pci_create_simple_multifunction 
> (bus=0x5555563d32b0, devfn=96, multifunction=true, name=0x555555c9b63b 
> "vt8231-isa") at hw/pci/pci.c:2189
>   #20 0x0000555555867730 in pegasos2_init (machine=0x5555560427a0) at 
> hw/ppc/pegasos2.c:105
>
> The "isa-pit" type (TYPE_I8254) is missing. Add it.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  hw/isa/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>