[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/8] hw/riscv: virt: Switch to use qemu_fdt_setprop_string_ar
|
From: |
Alistair Francis |
|
Subject: |
Re: [PATCH 2/8] hw/riscv: virt: Switch to use qemu_fdt_setprop_string_array() helper |
|
Date: |
Wed, 31 Mar 2021 11:41:50 -0400 |
On Mon, Mar 29, 2021 at 1:17 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> From: Bin Meng <bin.meng@windriver.com>
>
> Since commit 78da6a1bca22 ("device_tree: add qemu_fdt_setprop_string_array
> helper"),
> we can use the new helper to set the compatible strings for the
> SiFive test device node.
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
>
> hw/riscv/virt.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
> index c0dc69ff33..5d0c1e5903 100644
> --- a/hw/riscv/virt.c
> +++ b/hw/riscv/virt.c
> @@ -395,8 +395,9 @@ static void create_fdt(RISCVVirtState *s, const
> MemMapEntry *memmap,
> (long)memmap[VIRT_TEST].base);
> qemu_fdt_add_subnode(fdt, name);
> {
> - const char compat[] = "sifive,test1\0sifive,test0\0syscon";
> - qemu_fdt_setprop(fdt, name, "compatible", compat, sizeof(compat));
> + const char *compat[3] = { "sifive,test1", "sifive,test0", "syscon" };
> + qemu_fdt_setprop_string_array(fdt, name, "compatible", (char
> **)&compat,
> + ARRAY_SIZE(compat));
> }
> qemu_fdt_setprop_cells(fdt, name, "reg",
> 0x0, memmap[VIRT_TEST].base,
> --
> 2.25.1
>
>
- [PATCH 1/8] hw/riscv: sifive_u: Switch to use qemu_fdt_setprop_string_array() helper, Bin Meng, 2021/03/29
- [PATCH 2/8] hw/riscv: virt: Switch to use qemu_fdt_setprop_string_array() helper, Bin Meng, 2021/03/29
- Re: [PATCH 2/8] hw/riscv: virt: Switch to use qemu_fdt_setprop_string_array() helper,
Alistair Francis <=
- [PATCH 4/8] hw/riscv: Support the official PLIC DT bindings, Bin Meng, 2021/03/29
- [PATCH 5/8] docs/system/riscv: Correct the indentation level of supported devices, Bin Meng, 2021/03/29
- [PATCH 3/8] hw/riscv: Support the official CLINT DT bindings, Bin Meng, 2021/03/29
- [PATCH 6/8] docs/system/riscv: sifive_u: Document '-dtb' usage, Bin Meng, 2021/03/29
- [PATCH 7/8] hw/riscv: Use macros for BIOS image names, Bin Meng, 2021/03/29