[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 5/5] tests/tcg: add HeapInfo checking to semihosting test
|
From: |
Alex Bennée |
|
Subject: |
Re: [PATCH v5 5/5] tests/tcg: add HeapInfo checking to semihosting test |
|
Date: |
Fri, 12 Mar 2021 11:23:05 +0000 |
|
User-agent: |
mu4e 1.5.10; emacs 28.0.50 |
Peter Maydell <peter.maydell@linaro.org> writes:
> On Fri, 12 Mar 2021 at 10:31, Alex Benn=C3=A9e <alex.bennee@linaro.org> wro=
> te:
>>
>> Query the SYS_HEAPINFO semicall and do some basic verification of the
>> information via libc calls.
>
> Are we both testing system emulation and linux-user, or just one of the two=
> ?
Currently just linux-user. There is no inherent reason we couldn't add a
system emulation test but I felt that was already reasonably exercised
by your semihosting tests.
> (Not that I want to hold this up if we're only testing one, but coverage
> of both, including M-profile, seems like it would be useful; cf also
> https://bugs.launchpad.net/qemu/+bug/1918302 which is M-profile system-emul=
> ation
> SYS_HEAPINFO being broken in 5.2.)
>
> thanks
> -- PMM
--
Alex Bennée
[PATCH v5 2/5] semihosting/arm-compat-semi: unify GET/SET_ARG helpers, Alex Bennée, 2021/03/12
[PATCH v5 3/5] semihosting/arm-compat-semi: don't use SET_ARG to report SYS_HEAPINFO, Alex Bennée, 2021/03/12
[PATCH v5 4/5] linux-user/riscv: initialise the TaskState heap/stack info, Alex Bennée, 2021/03/12