[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 3/5] semihosting/arm-compat-semi: don't use SET_ARG to rep
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH v5 3/5] semihosting/arm-compat-semi: don't use SET_ARG to report SYS_HEAPINFO |
|
Date: |
Fri, 12 Mar 2021 10:32:03 +0000 |
On Fri, 12 Mar 2021 at 10:29, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> As per the spec:
>
> the PARAMETER REGISTER contains the address of a pointer to a
> four-field data block.
>
> So we need to follow arg0 and place the results of SYS_HEAPINFO there.
>
> Fixes: 3c37cfe0b1 ("semihosting: Change internal common-semi interfaces to
> use CPUState *")
> Bug: https://bugs.launchpad.net/bugs/1915925
> Cc: Bug 1915925 <1915925@bugs.launchpad.net>
> Cc: Keith Packard <keithp@keithp.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>
> ---
> v3
> - just revert the old behaviour
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
[PATCH v5 2/5] semihosting/arm-compat-semi: unify GET/SET_ARG helpers, Alex Bennée, 2021/03/12
[PATCH v5 3/5] semihosting/arm-compat-semi: don't use SET_ARG to report SYS_HEAPINFO, Alex Bennée, 2021/03/12
- Re: [PATCH v5 3/5] semihosting/arm-compat-semi: don't use SET_ARG to report SYS_HEAPINFO,
Peter Maydell <=
[PATCH v5 4/5] linux-user/riscv: initialise the TaskState heap/stack info, Alex Bennée, 2021/03/12