Re: [PATCH 1/4] target/riscv: Make csr_ops[CSR_TABLE

qemu-riscv

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/4] target/riscv: Make csr_ops[CSR_TABLE_SIZE] external

From:	Richard Henderson
Subject:	Re: [PATCH 1/4] target/riscv: Make csr_ops[CSR_TABLE_SIZE] external
Date:	Mon, 18 Jan 2021 07:55:37 -1000
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 1/11/21 6:52 PM, Bin Meng wrote:
> +extern riscv_csr_operations csr_ops[];

You might as well use CSR_TABLE_SIZE here.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 0/4] target/riscv: Generate the GDB XML file for CSR registers dynamically, Bin Meng, 2021/01/11
- [PATCH 1/4] target/riscv: Make csr_ops[CSR_TABLE_SIZE] external, Bin Meng, 2021/01/11
  - Re: [PATCH 1/4] target/riscv: Make csr_ops[CSR_TABLE_SIZE] external, Alistair Francis, 2021/01/15
  - Re: [PATCH 1/4] target/riscv: Make csr_ops[CSR_TABLE_SIZE] external, Richard Henderson <=
    - Re: [PATCH 1/4] target/riscv: Make csr_ops[CSR_TABLE_SIZE] external, Bin Meng, 2021/01/18
- [PATCH 2/4] target/riscv: Add CSR name in the CSR function table, Bin Meng, 2021/01/11
  - Re: [PATCH 2/4] target/riscv: Add CSR name in the CSR function table, Alexander Richardson, 2021/01/15
    - Re: [PATCH 2/4] target/riscv: Add CSR name in the CSR function table, Bin Meng, 2021/01/15
    - Re: [PATCH 2/4] target/riscv: Add CSR name in the CSR function table, Alistair Francis, 2021/01/15
  - Re: [PATCH 2/4] target/riscv: Add CSR name in the CSR function table, Alistair Francis, 2021/01/15
- [PATCH 3/4] target/riscv: Generate the GDB XML file for CSR registers dynamically, Bin Meng, 2021/01/11
  - Re: [PATCH 3/4] target/riscv: Generate the GDB XML file for CSR registers dynamically, Alistair Francis, 2021/01/15
    - Re: [PATCH 3/4] target/riscv: Generate the GDB XML file for CSR registers dynamically, Alistair Francis, 2021/01/15
    - Re: [PATCH 3/4] target/riscv: Generate the GDB XML file for CSR registers dynamically, Bin Meng, 2021/01/15

Prev by Date: Re: [PATCH v1 1/1] riscv: Pass RISCVHartArrayState by pointer
Next by Date: Re: [PATCH 1/4] target/riscv: Make csr_ops[CSR_TABLE_SIZE] external
Previous by thread: Re: [PATCH 1/4] target/riscv: Make csr_ops[CSR_TABLE_SIZE] external
Next by thread: Re: [PATCH 1/4] target/riscv: Make csr_ops[CSR_TABLE_SIZE] external
Index(es):
- Date
- Thread