[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/riscv/pmp: Raise exception if no PMP entry is configu
|
From: |
Atish Patra |
|
Subject: |
Re: [PATCH] target/riscv/pmp: Raise exception if no PMP entry is configured |
|
Date: |
Wed, 23 Dec 2020 19:26:23 +0000 |
|
User-agent: |
Evolution 3.38.2 |
On Tue, 2020-12-22 at 18:49 -0800, Richard Henderson wrote:
> On 12/22/20 5:21 PM, Atish Patra wrote:
> > +++ b/target/riscv/pmp.c
> > @@ -74,7 +74,7 @@ static inline int pmp_is_locked(CPURISCVState
> > *env, uint32_t pmp_index)
> > /*
> > * Count the number of active rules.
> > */
> > -static inline uint32_t pmp_get_num_rules(CPURISCVState *env)
> > +inline uint32_t pmp_get_num_rules(CPURISCVState *env)
> > {
> > return env->pmp_state.num_rules;
> > }
> ...
> > --- a/target/riscv/pmp.h
> > +++ b/target/riscv/pmp.h
> > @@ -64,5 +64,6 @@ bool pmp_is_range_in_tlb(CPURISCVState *env,
> > hwaddr tlb_sa,
> > target_ulong *tlb_size);
> > void pmp_update_rule_addr(CPURISCVState *env, uint32_t pmp_index);
> > void pmp_update_rule_nums(CPURISCVState *env);
> > +uint32_t pmp_get_num_rules(CPURISCVState *env);
>
> You need to remove the inline as well.
>
Of course. Fixed in v2. Thanks.
>
> r~
--
Regards,
Atish