[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] semihosting: Move ARM semihosting code to shared directo
From: |
Keith Packard |
Subject: |
Re: [PATCH 1/4] semihosting: Move ARM semihosting code to shared directories |
Date: |
Tue, 27 Oct 2020 14:56:01 -0700 |
Peter Maydell <peter.maydell@linaro.org> writes:
>> +specific_ss.add(when: 'CONFIG_TCG', if_true: files ('common-semi.c'))
>
> I think this adds this file to the compilation for all TCG targets;
> you only want it for targets which have Arm-semihosting-ABI compatible
> semihosting. (Various other targets either don't have semihosting
> or have their own ABI.)
Right. These should have been target-specific source sets so that the
file was only added to those targets:
arm_ss.add(when: 'CONFIG_TCG', if_true: files ('common-semi.c'))
riscv_ss.add(files('common-semi.c'))
This appears to work in my testing (building arm, risc-v and x86_64
configs).
--
-keith
signature.asc
Description: PGP signature
[PATCH 3/4] semihosting: Change internal common-semi interfaces to use CPUState *, Keith Packard, 2020/10/26
[PATCH 4/4] riscv: Add semihosting support [v10], Keith Packard, 2020/10/26
Re: [PATCH 0/4] riscv: Add semihosting support [v10], no-reply, 2020/10/26