[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC 63/65] fpu: implement full set compare for fp16

From: Chih-Min Chao
Subject: Re: [RFC 63/65] fpu: implement full set compare for fp16
Date: Tue, 14 Jul 2020 17:29:37 +0800

On Fri, Jul 10, 2020 at 8:26 PM Alex Bennée <alex.bennee@linaro.org> wrote:

Alex Bennée <alex.bennee@linaro.org> writes:

> frank.chang@sifive.com writes:
>> From: Kito Cheng <kito.cheng@sifive.com>
>> Signed-off-by: Kito Cheng <kito.cheng@sifive.com>
>> Signed-off-by: Chih-Min Chao <chihmin.chao@sifive.com>
>> Signed-off-by: Frank Chang <frank.chang@sifive.com>
> NACK I'm afraid. What's wrong with the exiting float_compare support?
> Even if you did want to bring in aliases for these functions within
> softfloat itself the correct way would be to use the decomposed
> float_compare support for a bunch of stubs and not restore the old style
> error prone bit masking code.

In fact see the example float32_eq inline function in the softfloat.h header.

Alex Bennée

Hi Alex,

Thanks for the suggestion of using wrong and old implementation and this part will be refined in next separated softfloat PR.

Chih-Min Chao

reply via email to

[Prev in Thread] Current Thread [Next in Thread]