[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC 11/65] target/riscv: rvv-0.9: add fractional LMUL, VTA and VMA
|
From: |
Richard Henderson |
|
Subject: |
Re: [RFC 11/65] target/riscv: rvv-0.9: add fractional LMUL, VTA and VMA |
|
Date: |
Fri, 10 Jul 2020 10:45:30 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 7/10/20 3:48 AM, frank.chang@sifive.com wrote:
> -static void vext_clear(void *tail, uint32_t cnt, uint32_t tot)
> +static void vext_clear(void *tail, uint32_t vta, uint32_t cnt, uint32_t tot)
> {
> + /* tail element undisturbed */
> + if (vta == 0) {
> + return;
> + }
> +
> memset(tail, 0, tot - cnt);
> }
First, this patch is doing too much. LMUL should definitely be split from
VTA/VMA; they are not functionally related.
Second, it would be in-spec to simply do nothing for VTA/VMA, except validate
their setting within VTYPE.
Third, the spec talks about setting "agnostic" values to 1s, not 0s as you are
doing here. So there's definitely something wrong.
r~
- Re: [RFC 60/65] softfloat: add fp16 and uint8/int8 interconvert functions, (continued)
[RFC 63/65] fpu: implement full set compare for fp16, frank . chang, 2020/07/10
[RFC 11/65] target/riscv: rvv-0.9: add fractional LMUL, VTA and VMA, frank . chang, 2020/07/10
- Re: [RFC 11/65] target/riscv: rvv-0.9: add fractional LMUL, VTA and VMA,
Richard Henderson <=
[RFC 12/65] target/riscv: rvv-0.9: update check functions, frank . chang, 2020/07/10
[RFC 17/65] target/riscv: rvv-0.9: fault-only-first unit stride load, frank . chang, 2020/07/10
[RFC 18/65] target/riscv: rvv-0.9: amo operations, frank . chang, 2020/07/10
[RFC 29/65] target/riscv: rvv-0.9: integer scalar move instructions, frank . chang, 2020/07/10
[RFC 36/65] target/riscv: rvv-0.9: widening integer multiply-add instructions, frank . chang, 2020/07/10
[RFC 41/65] target/riscv: rvv-0.9: floating-point compare instructions, frank . chang, 2020/07/10
[RFC 42/65] target/riscv: rvv-0.9: single-width integer reduction instructions, frank . chang, 2020/07/10
[RFC 46/65] target/riscv: rvv-0.9: slide instructions, frank . chang, 2020/07/10