[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH v2 15/23] hw/m68k/mcf520x: Emit warning when old code is used
From: |
Philippe Mathieu-Daudé |
Subject: |
[RFC PATCH v2 15/23] hw/m68k/mcf520x: Emit warning when old code is used |
Date: |
Sat, 4 Jul 2020 17:39:00 +0200 |
This code hasn't been QOM'ified yet. Warn the user.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
v2: Add comment (thuth)
---
hw/m68k/mcf5206.c | 5 +++++
hw/m68k/mcf5208.c | 3 +++
2 files changed, 8 insertions(+)
diff --git a/hw/m68k/mcf5206.c b/hw/m68k/mcf5206.c
index a2fef04f8e..ec0d176674 100644
--- a/hw/m68k/mcf5206.c
+++ b/hw/m68k/mcf5206.c
@@ -16,6 +16,7 @@
#include "qemu/timer.h"
#include "hw/ptimer.h"
#include "sysemu/sysemu.h"
+#include "hw/qdev-deprecated.h"
/* General purpose timer module. */
typedef struct {
@@ -144,6 +145,8 @@ static m5206_timer_state *m5206_timer_init(qemu_irq irq)
{
m5206_timer_state *s;
+ qdev_warn_deprecated_function_used();
+
s = g_new0(m5206_timer_state, 1);
s->timer = ptimer_init(m5206_timer_trigger, s, PTIMER_POLICY_DEFAULT);
s->irq = irq;
@@ -566,6 +569,8 @@ qemu_irq *mcf5206_init(MemoryRegion *sysmem, uint32_t base,
M68kCPU *cpu)
m5206_mbar_state *s;
qemu_irq *pic;
+ qdev_warn_deprecated_function_used();
+
s = g_new0(m5206_mbar_state, 1);
memory_region_init_io(&s->iomem, NULL, &m5206_mbar_ops, s,
diff --git a/hw/m68k/mcf5208.c b/hw/m68k/mcf5208.c
index d310a98e7b..0bfcbb6332 100644
--- a/hw/m68k/mcf5208.c
+++ b/hw/m68k/mcf5208.c
@@ -26,6 +26,7 @@
#include "hw/sysbus.h"
#include "elf.h"
#include "exec/address-spaces.h"
+#include "hw/qdev-deprecated.h"
#define SYS_FREQ 166666666
@@ -194,7 +195,9 @@ static void mcf5208_sys_init(MemoryRegion *address_space,
qemu_irq *pic)
/* SDRAMC. */
memory_region_init_io(iomem, NULL, &m5208_sys_ops, NULL, "m5208-sys",
0x00004000);
memory_region_add_subregion(address_space, 0xfc0a8000, iomem);
+
/* Timers. */
+ qdev_warn_deprecated_function_used(); /* m5208_timer_state is not QOM */
for (i = 0; i < 2; i++) {
s = g_new0(m5208_timer_state, 1);
s->timer = ptimer_init(m5208_timer_trigger, s, PTIMER_POLICY_DEFAULT);
--
2.21.3
- [RFC PATCH v2 07/23] hw/display/blizzard: Emit warning when old code is used, (continued)
- [RFC PATCH v2 07/23] hw/display/blizzard: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 08/23] hw/display/ramfb: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 09/23] hw/display/tc6393xb: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 10/23] hw/display/vga-isa-mm: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 11/23] hw/dma/etraxfs_dma: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 13/23] hw/input/lasips2: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 12/23] hw/dma/soc_dma: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 14/23] hw/input/tsc2005: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 15/23] hw/m68k/mcf520x: Emit warning when old code is used,
Philippe Mathieu-Daudé <=
- [RFC PATCH v2 16/23] hw/misc/cbus: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 17/23] hw/nvram/eeprom93xx: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 18/23] hw/openrisc/cputimer: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 19/23] hw/ppc/ppc4xx: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 20/23] hw/sh4: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 21/23] hw/riscv: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 22/23] hw/usb/hcd-musb: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04