[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 05/10] Makefile: Remove dangerous EOL trailing backslash
|
From: |
Alistair Francis |
|
Subject: |
Re: [PATCH v2 05/10] Makefile: Remove dangerous EOL trailing backslash |
|
Date: |
Mon, 18 May 2020 09:46:52 -0700 |
On Fri, May 15, 2020 at 10:11 AM Philippe Mathieu-Daudé
<address@hidden> wrote:
>
> One might get caught trying to understand unexpected Makefile
> behavior. Trailing backslash can help to split very long lines,
> but are rather dangerous when nothing follow. Preserve other
> developers debugging time by removing this one.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Alistair
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 34275f57c9..84453789f9 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -420,7 +420,7 @@ MINIKCONF_ARGS = \
>
> MINIKCONF_INPUTS = $(SRC_PATH)/Kconfig.host $(SRC_PATH)/hw/Kconfig
> MINIKCONF_DEPS = $(MINIKCONF_INPUTS) $(wildcard $(SRC_PATH)/hw/*/Kconfig)
> -MINIKCONF = $(PYTHON) $(SRC_PATH)/scripts/minikconf.py \
> +MINIKCONF = $(PYTHON) $(SRC_PATH)/scripts/minikconf.py
>
> $(SUBDIR_DEVICES_MAK): %/config-devices.mak: default-configs/%.mak
> $(MINIKCONF_DEPS) $(BUILD_DIR)/config-host.mak
> $(call quiet-command, $(MINIKCONF) $(MINIKCONF_ARGS) > $@.tmp, "GEN",
> "$@.tmp")
> --
> 2.21.3
>
>
- [PATCH v2 01/10] MAINTAINERS: Fix KVM path expansion glob, (continued)
- [PATCH v2 01/10] MAINTAINERS: Fix KVM path expansion glob, Philippe Mathieu-Daudé, 2020/05/15
- [PATCH v2 02/10] MAINTAINERS: Add an 'overall' entry for accelerators, Philippe Mathieu-Daudé, 2020/05/15
- [PATCH v2 03/10] MAINTAINERS: Add an entry for the HAX accelerator, Philippe Mathieu-Daudé, 2020/05/15
- [PATCH v2 04/10] accel/tcg: Add stub for probe_access(), Philippe Mathieu-Daudé, 2020/05/15
- [PATCH v2 05/10] Makefile: Remove dangerous EOL trailing backslash, Philippe Mathieu-Daudé, 2020/05/15
- [PATCH v2 06/10] Makefile: Write MINIKCONF variables as one entry per line, Philippe Mathieu-Daudé, 2020/05/15
- [PATCH v2 07/10] accel/Kconfig: Extract accel selectors into their own config, Philippe Mathieu-Daudé, 2020/05/15
- [PATCH v2 08/10] accel/Kconfig: Add the TCG selector, Philippe Mathieu-Daudé, 2020/05/15
- [PATCH v2 09/10] Makefile: Allow target-specific optional Kconfig, Philippe Mathieu-Daudé, 2020/05/15
- [PATCH v2 10/10] hw/semihosting: Make the feature depend of TCG, and allow to disable it, Philippe Mathieu-Daudé, 2020/05/15
- Re: [PATCH v2 00/10] accel: Allow targets to use Kconfig, disable semihosting by default, no-reply, 2020/05/15