[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 20/60] target/riscv: vector single-width integer multiply-
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v5 20/60] target/riscv: vector single-width integer multiply-add instructions |
|
Date: |
Sat, 14 Mar 2020 00:10:04 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 3/12/20 7:58 AM, LIU Zhiwei wrote:
> +#define OPIVX3(NAME, TD, T1, T2, TX1, TX2, HD, HS2, OP) \
> +static void do_##NAME(void *vd, target_ulong s1, void *vs2, int i) \
> +{ \
> + TX2 s2 = *((T2 *)vs2 + HS2(i)); \
> + TD d = *((TD *)vd + HD(i)); \
> + *((TD *)vd + HD(i)) = OP(s2, (TX1)(T1)(target_long)s1, d); \
> +}
Change the type of s1? Otherwise,
Reviewed-by: Richard Henderson <address@hidden>
r~
- [PATCH v5 16/60] target/riscv: vector integer min/max instructions, (continued)
- [PATCH v5 16/60] target/riscv: vector integer min/max instructions, LIU Zhiwei, 2020/03/12
- [PATCH v5 17/60] target/riscv: vector single-width integer multiply instructions, LIU Zhiwei, 2020/03/12
- [PATCH v5 18/60] target/riscv: vector integer divide instructions, LIU Zhiwei, 2020/03/12
- [PATCH v5 19/60] target/riscv: vector widening integer multiply instructions, LIU Zhiwei, 2020/03/12
- [PATCH v5 20/60] target/riscv: vector single-width integer multiply-add instructions, LIU Zhiwei, 2020/03/12
- Re: [PATCH v5 20/60] target/riscv: vector single-width integer multiply-add instructions,
Richard Henderson <=
- [PATCH v5 21/60] target/riscv: vector widening integer multiply-add instructions, LIU Zhiwei, 2020/03/12
- [PATCH v5 22/60] target/riscv: vector integer merge and move instructions, LIU Zhiwei, 2020/03/12
- [PATCH v5 23/60] target/riscv: vector single-width saturating add and subtract, LIU Zhiwei, 2020/03/12
- [PATCH v5 24/60] target/riscv: vector single-width averaging add and subtract, LIU Zhiwei, 2020/03/12