[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/riscv: Bugfix reserved bits in PTE for RV64
From: |
Alistair Francis |
Subject: |
Re: [PATCH] target/riscv: Bugfix reserved bits in PTE for RV64 |
Date: |
Mon, 23 Sep 2019 22:03:27 -0700 |
On Mon, Sep 23, 2019 at 10:01 PM <address@hidden> wrote:
>
> From: Guo Ren <address@hidden>
>
> Highest 10 bits of PTE are reserved in riscv-privileged, ref: [1], so we
> need to ignore them. They can not be a part of ppn.
>
> 1: The RISC-V Instruction Set Manual, Volume II: Privileged Architecture
> 4.4 Sv39: Page-Based 39-bit Virtual-Memory System
> 4.5 Sv48: Page-Based 48-bit Virtual-Memory System
>
> Signed-off-by: Guo Ren <address@hidden>
> Reviewed-by: Liu Zhiwei <address@hidden>
> ---
> target/riscv/cpu_helper.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c
> index 87dd6a6..3c5e8f6 100644
> --- a/target/riscv/cpu_helper.c
> +++ b/target/riscv/cpu_helper.c
> @@ -260,6 +260,7 @@ restart:
> target_ulong pte = ldl_phys(cs->as, pte_addr);
> #elif defined(TARGET_RISCV64)
> target_ulong pte = ldq_phys(cs->as, pte_addr);
> + pte = pte << 10 >> 10;
You can just AND with a mask instead of shifting both directions.
Alistair
> #endif
> hwaddr ppn = pte >> PTE_PPN_SHIFT;
>
> --
> 2.7.4
>