[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-riscv] [Qemu-devel] [PATCH v1 6/7] target/riscv: rationalise s
From: |
Richard Henderson |
Subject: |
Re: [Qemu-riscv] [Qemu-devel] [PATCH v1 6/7] target/riscv: rationalise softfloat includes |
Date: |
Thu, 8 Aug 2019 10:57:03 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 8/8/19 9:41 AM, Alex Bennée wrote:
> We should avoid including the whole of softfloat headers in cpu.h and
> explicitly include it only where we will be calling softfloat
> functions. We can use the -types.h and -helpers.h in cpu.h for the few
> bits that are global.
>
> Signed-off-by: Alex Bennée <address@hidden>
> ---
> target/riscv/cpu.c | 1 +
> target/riscv/cpu.h | 2 +-
> target/riscv/fpu_helper.c | 1 +
> 3 files changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson <address@hidden>
r~