[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-riscv] [Qemu-devel] [PATCH] atomic failures on qemu-system-ris

From: Palmer Dabbelt
Subject: Re: [Qemu-riscv] [Qemu-devel] [PATCH] atomic failures on qemu-system-riscv64
Date: Tue, 25 Jun 2019 23:07:53 -0700 (PDT)

On Tue, 25 Jun 2019 08:39:21 PDT (-0700), address@hidden wrote:
On 6/24/19 8:08 PM, Joel Sing wrote:
From 8ef31a2ce8ef1cbeee92995a0b2994f480e9bb6d Mon Sep 17 00:00:00 2001
From: Joel Sing <address@hidden>
Date: Tue, 25 Jun 2019 02:44:24 +1000
Subject: [PATCH] Clear load reservations on qemu riscv target

This prevents a load reservation from being placed in one context/process,
then being used in another, resulting in an SC succeeding incorrectly and
breaking atomics.

Signed-off-by: Joel Sing <address@hidden>

Reviewed-by: Richard Henderson <address@hidden>

+    /* Clear the load reservation - otherwise a reservation placed in one

Excepting this line, which will fail checkpatch.pl.
Needs to be formatted as

     * Clear the load...

Thanks.  I fixed that one up as I pulled the patch in.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]